-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop versions below PHP 7.2 #19
Conversation
i think this must be done
Why not support PHP 7.0 and 7.1 ? |
because of this : https://www.php.net/supported-versions.php, prior of this i see that atk4/data drop support for php below 7.2. We can leave this to support >7.0 and let composer resolve requirements if used with other packages. I open this issue while I was showing to one of my dev the library and i see that it was required 5.6. |
Yeah, probably you're right about 7.2. If data don't support php <7.2, then it's useless to try to run api on 7.0 or 7.1. Please also add fix for travis.yml (remove 7.0, 7.1 and maybe add 7.3) and let @romaninsh decide what to do with this. |
@romaninsh in travis i removed the lines targeting php version for coverage, please check it. |
@abbadon1334 Why did you remove code coverage sending? I think it was fine, just needed to change 7.0 to 7.2. |
/dev/fd/63: eval: line 1257: unexpected EOF while looking for matching `]' /dev/fd/63: eval: line 1258: syntax error: unexpected end of file
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
==========================================
Coverage ? 34.75%
Complexity ? 76
==========================================
Files ? 1
Lines ? 164
Branches ? 0
==========================================
Hits ? 57
Misses ? 107
Partials ? 0 Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
==========================================
Coverage ? 34.75%
Complexity ? 76
==========================================
Files ? 1
Lines ? 164
Branches ? 0
==========================================
Hits ? 57
Misses ? 107
Partials ? 0 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
==========================================
Coverage ? 34.75%
Complexity ? 76
==========================================
Files ? 1
Lines ? 164
Branches ? 0
==========================================
Hits ? 57
Misses ? 107
Partials ? 0 Continue to review full report at Codecov.
|
Coverage is back, sorry. I see a losing of coverage, if you want to merge this PR, i will look further in the issue and i will open another one only to increase coverage, because i think api must have higher rate of testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now all looks good, merging
i think this must be done