-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation-guide.md #1420
base: master
Are you sure you want to change the base?
Conversation
|
WalkthroughThis update refines a sentence in the installation guide documentation to clarify the upgrade instructions. The revised sentence now directly instructs users to upgrade NPM or Node if their version is below the recommended level, ensuring the guidance is straightforward. Changes
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
We require all PRs to follow Conventional Commits specification.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/generator/docs/installation-guide.md (1)
25-26
: Enhance Clarity for Upgrade InstructionsThe updated sentence is clearer in instructing users to upgrade if their installed versions are below the recommended levels. However, the phrase “if your version is lower than the recommended one” can be slightly ambiguous since there are separate recommendations for Node.js and NPM. Consider rephrasing to explicitly mention both tools.
For example:
-If you have the correct versions installed, proceed to the CLI installation guide below. Otherwise, upgrade NPM or Node if your version is lower than the recommended one. +If you have the correct versions installed, proceed to the CLI installation guide below. Otherwise, if either your Node.js or NPM version is below the recommended level, please upgrade them to continue.
Hey @Lalit159 you should change the PR title. Always look for the workflow result whenever you make a PR or create an Issue. |
@Lalit159 bot has commented for the supported titles |
@Lalit159
for this simple commit, you can change the title to: |
Description
Related issue(s)
Summary by CodeRabbit