Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the async execution mode read sql files for dbt packages #1588

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Mar 4, 2025

closes: #1585

This PR modifies the DbtNode to include the packages,
allowing us to correctly construct the path when reading
the generated SQL files. In DBT projects with dbt_packages,
the dbt run command generates SQL files within the respective
dbt_packages folder inside the target/run directory, instead of
the main project folder.

Screenshot 2025-03-06 at 12 01 51 AM

With Setup task

Screenshot 2025-03-06 at 12 02 58 AM

Without Setup task

Screenshot 2025-03-06 at 12 03 34 AM

Copy link

cloudflare-workers-and-pages bot commented Mar 4, 2025

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2052715
Status: ✅  Deploy successful!
Preview URL: https://4572eb3d.astronomer-cosmos.pages.dev
Branch Preview URL: https://fix-read-path.astronomer-cosmos.pages.dev

View logs

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit 2052715
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67c894713993040008a0e224

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.36%. Comparing base (e31fc5b) to head (2052715).

Files with missing lines Patch % Lines
cosmos/operators/local.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1588   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files          80       80           
  Lines        4934     4936    +2     
=======================================
+ Hits         4804     4806    +2     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pankajastro pankajastro marked this pull request as ready for review March 5, 2025 18:34
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc dbt:run Primarily related to dbt run command or functionality labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc dbt:run Primarily related to dbt run command or functionality size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ASYNC execution mode "No such file or directory" while reading generated SQL from target folder
1 participant