Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing #29

Draft
wants to merge 1 commit into
base: astria
Choose a base branch
from

testing

ff608b1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

testing #29

testing
ff608b1
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy-no-default-features failed Feb 25, 2025 in 0s

clippy-no-default-features

8 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 8
Warning 0
Note 0
Help 0

Versions

  • rustc 1.85.0 (4d91de4e4 2025-02-17)
  • cargo 1.85.0 (d73d2caf9 2024-12-31)
  • clippy 0.1.85 (4d91de4e48 2025-02-17)

Annotations

Check failure on line 90 in crates/relayer-types/src/mock/consensus_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

useless conversion to the same type: `core::ics02_client::error::Error`

error: useless conversion to the same type: `core::ics02_client::error::Error`
  --> crates/relayer-types/src/mock/consensus_state.rs:90:58
   |
90 |                   decode_consensus_state(raw.value.deref()).map_err(Into::into)
   |  __________________________________________________________-^^^^^^^^^^^^^^^^^^^
91 | |             }
   | |____________- help: consider removing
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 92 in crates/relayer-types/src/mock/client_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

useless conversion to the same type: `core::ics02_client::error::Error`

error: useless conversion to the same type: `core::ics02_client::error::Error`
  --> crates/relayer-types/src/mock/client_state.rs:92:55
   |
92 |                   decode_client_state(raw.value.deref()).map_err(Into::into)
   |  _______________________________________________________-^^^^^^^^^^^^^^^^^^^
93 | |             }
   | |____________- help: consider removing
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `-D clippy::useless-conversion` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

Check failure on line 75 in crates/relayer-types/src/utils/pretty.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> crates/relayer-types/src/utils/pretty.rs:75:6
   |
75 | impl<'a, T: Display> Display for PrettySlice<'a, T> {
   |      ^^                                      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
75 - impl<'a, T: Display> Display for PrettySlice<'a, T> {
75 + impl<T: Display> Display for PrettySlice<'_, T> {
   |

Check failure on line 26 in crates/relayer-types/src/utils/pretty.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> crates/relayer-types/src/utils/pretty.rs:26:6
   |
26 | impl<'a, T: Display> Display for PrettyOption<'a, T> {
   |      ^^                                       ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
26 - impl<'a, T: Display> Display for PrettyOption<'a, T> {
26 + impl<T: Display> Display for PrettyOption<'_, T> {
   |

Check failure on line 144 in crates/relayer-types/src/core/ics04_channel/packet.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> crates/relayer-types/src/core/ics04_channel/packet.rs:144:6
    |
144 | impl<'a> core::fmt::Debug for PacketData<'a> {
    |      ^^                                  ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
144 - impl<'a> core::fmt::Debug for PacketData<'a> {
144 + impl core::fmt::Debug for PacketData<'_> {
    |

Check failure on line 412 in crates/relayer-types/src/core/ics03_connection/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

function cannot return without recursing

error: function cannot return without recursing
   --> crates/relayer-types/src/core/ics03_connection/connection.rs:410:5
    |
410 | /     fn from(value: State) -> Self {
411 | |         value.into()
412 | |     }
    | |_____^
    |
note: recursive call site
   --> crates/relayer-types/src/core/ics03_connection/connection.rs:411:9
    |
411 |         value.into()
    |         ^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion
    = note: `-D clippy::unconditional-recursion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::unconditional_recursion)]`

Check failure on line 9 in crates/relayer-types/src/core/ics03_connection/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

importing legacy numeric constants

error: importing legacy numeric constants
 --> crates/relayer-types/src/core/ics03_connection/connection.rs:9:5
  |
9 |     u64,
  |     ^^^
  |
  = help: remove this import
  = note: then `u64::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
  = note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`

Check failure on line 239 in crates/relayer-types/src/core/ics02_client/trust_threshold.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

the following explicit lifetimes could be elided: 'de

error: the following explicit lifetimes could be elided: 'de
   --> crates/relayer-types/src/core/ics02_client/trust_threshold.rs:239:10
    |
239 |     impl<'de> Visitor<'de> for StringOrInt {
    |          ^^^          ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
    |
239 -     impl<'de> Visitor<'de> for StringOrInt {
239 +     impl Visitor<'_> for StringOrInt {
    |