fix(sequencer): update put_price_for_currency_pair
#1959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update
put_price_for_currency_pair
to error if state is not found. this is correct as the function is only called fromapply_prices_from_vote_extensions
, which only contains currency pairs that are already in the app state, as an invariant of theid_to_currency_pair
validation done insidevalidate_id_to_currency_pair_mapping
. thus, the previouselse
case where the state didn't exist would never be hit.Background
resolves oracle audit issue 3.1.
Changes
put_price_for_currency_pair
to error if state is not found.Testing
existing unit tests