Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update normalize_by_pair to be optional #1851

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

noot
Copy link
Collaborator

@noot noot commented Dec 4, 2024

Summary

update normalize_by_pair to be optional and fix default market map genesis.

Background

connect sidecar can now run without specifying a markets.json, can now just get the market map from the sequencer.

Changes

  • update normalize_by_pair to be optional as it should be optional
  • fix default market map genesis

Testing

ran connect sidecar locally; change sequencer gRPC port to 9090 and run:
./build/connect --port 8081

run sequencer+cometbft as normal, should see sidecar logs like:

{"level":"info","ts":"2024-12-04T15:38:30.423-0500","caller":"marketmap/fetcher.go:128","msg":"successfully fetched market map data from module; checking if market map has changed","pid":8547,"process":"oracle","fetcher":"marketmap_api"}

@noot noot requested a review from a team as a code owner December 4, 2024 21:07
@noot noot requested a review from Fraser999 December 4, 2024 21:07
@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Dec 4, 2024
@noot noot merged commit 80be7eb into feat/oracle Dec 5, 2024
45 checks passed
@noot noot deleted the noot/fix-provider-cfg branch December 5, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants