feat(sequencer, core, conductor): pass oracle data to rollup via execution API #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or third injected tx
…tendedCommitInfoWithCurrencyPairMapping
github-actions
bot
added
conductor
SuperFluffy
requested changes
Dec 3, 2024
| @@ -458,7 +461,8 @@ impl Executor { | |||
| ))] | |||
| async fn execute_firm(&mut self, block: ReconstructedBlock) -> eyre::Result<()> { | |||
| let celestia_height = block.celestia_height; | |||
| let executable_block = ExecutableBlock::from_reconstructed(block); | |||
| let executable_block = ExecutableBlock::from_reconstructed(block) | |||
| .wrap_err("failed to construct executable block")?; | |||
There was a problem hiding this comment.
This should not fail. Reconstructed blocks should be completely valid blocks. Nothing that reaches the execution task should be invalid.
There was a problem hiding this comment.
updated to be infallible - no oracle data is added to the txs if it can't be constructed.
| @@ -697,23 +701,44 @@ struct ExecutableBlock { | |||
| } | |||
|
|
|||
| impl ExecutableBlock { | |||
| fn from_reconstructed(block: ReconstructedBlock) -> Self { | |||
| fn from_reconstructed(block: ReconstructedBlock) -> eyre::Result<Self> { | |||
There was a problem hiding this comment.
This should not be fallible.
Fraser999
approved these changes
Dec 4, 2024
| votes: vec![], | ||
| } | ||
| .into(); | ||
| let extended_commit_info_with_mapping = astria_core::generated::protocol::connect::v1::ExtendedCommitInfoWithCurrencyPairMapping { |
There was a problem hiding this comment.
I think the formatting is off here due to the line length. Maybe you could import astria_core::generated::protocol::connect::v1::ExtendedCommitInfoWithCurrencyPairMapping to fix this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update conductor to pass oracle data to rollup via execution API.
Background
this is the final change needed within the astria monorepo for the oracle integration, as the oracle data is now fully passed up the stack. handling the oracle data is now left up to each rollup.
Changes
OracleDatavariant to theRollupDataenum, which contains aVec<Price>, where eachPricecontains the relevant oracle data for a currency pair for that blockExtendedCommitInfoWithCurrencyPairMappingsuch that the id->currency pair mapping also contains the decimals for that currency pair's price; this is necessary information that I overlooked in the previous PR creating that typeFilteredSequencerBlockSequencerBlock,FilteredSequencerBlockandSubmittedMetadataconstructors such that the extended commit info bytes must be a valid encoded protobufExtendedCommitInfoWithCurrencyPairMappingRollupData::OracleDatato the rollup via the execution APITesting
unit tests
Related Issues
closes #1818