fix(sequencer): provide unit tests and fixes for vote extensions #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
requested review from
SuperFluffy and
noot
and removed request for
SuperFluffy
noot
reviewed
Nov 26, 2024
| prices | ||
| let Some(lower_index) = midpoint.checked_sub(1) else { | ||
| // We can only get here if `price_list` is empty; just return 0. | ||
| return Price::new(0); |
There was a problem hiding this comment.
the price list should never be empty if constructed correctly in the caller, arguably this should error/panic as silently returning 0 could be bad
There was a problem hiding this comment.
I agree as currently called, this line should never get hit. I'll change this to return an error, but in apply_prices_from_vote_extensions where we iterate over all the medians, I'll just skip any medians which errored. That way, a bug here won't halt block production.
noot
approved these changes
Nov 27, 2024
Fraser999
added a commit
that referenced
this pull request
Nov 27, 2024
## Summary This is a simple merge of `main`. It is based on top of the commits in `noot/more-tests` which forms PR #1836, so this is blocked by that PR. ## Background We want to keep the feature branch as in sync with `main` as possible. ## Changes - Merged `main`. Surprisingly few conflicts, and all trivial: only three in the following files: - crates/astria-core/Cargo.toml - crates/astria-core/src/generated/mod.rs - crates/astria-core/src/lib.rs ## Testing No new tests added. ## Changelogs No updates required. --------- Co-authored-by: Itamar Reif <9663129+itamarreif@users.noreply.github.com> Co-authored-by: quasystaty <ido@astria.org> Co-authored-by: Jordan Oroshiba <jordan@astria.org> Co-authored-by: elizabeth <elizabethjbinks@gmail.com> Co-authored-by: Ethan Oroshiba <ethan@astria.org> Co-authored-by: noot <36753753+noot@users.noreply.github.com> Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase test coverage of the
app::vote_extensionsmodule and fixes issues discovered while implementing these tests.Background
This was work spun out of previous PRs to this feature branch to allow parallelizing efforts to complete the feature.
Changes
app::vote_extensionsmodule.Testing
These are tests.
Changelogs
No updates required - the changelogs will be updated right before the feature merges to
main.