Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Naming Conventions for local Docker Builds #1743

Closed
quasystaty1 opened this issue Oct 25, 2024 · 0 comments · Fixed by #1744
Closed

Inconsistent Naming Conventions for local Docker Builds #1743

quasystaty1 opened this issue Oct 25, 2024 · 0 comments · Fixed by #1744

Comments

@quasystaty1
Copy link
Contributor

quasystaty1 commented Oct 25, 2024 •
edited by sync-by-unito bot
Loading

Description
We are experiencing issues with the naming conventions used in our local Docker build process. The current naming scheme leads to confusion an conflicts when deploying local images on the local cluster using just commands.

┆Issue Number: ENG-952
@quasystaty1 quasystaty1 mentioned this issue Oct 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@quasystaty1
fix(docker): correct local docker-build tag naming (#1744)
bd45898 
## Summary
This pull request addresses an issue with the naming conventions used in
the local Docker build process.

## Background
The build tags were previously not adhering to the expected naming
scheme, leading to confusion and potential conflicts during chart
deployment with local images using just commands.
## Changes
Updated the Docker build script to ensure tags are generated according
to the standard chart naming convention.

## Testing
locally running and deploying the chart both using
- `just docker-build-and-load astria-sequencer`
- `just docker-build astria-sequencer` && `just load-inage sequencer`

## Related Issues
closes #1743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docker): correct local docker-build tag naming astriaorg/astria
1 participant
@quasystaty1