Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequencer: rename sourceActionIndex to positionInTransaction #1735

Closed
ethanoroshiba opened this issue Oct 24, 2024 · 2 comments · Fixed by #1746
Closed

sequencer: rename sourceActionIndex to positionInTransaction #1735

ethanoroshiba opened this issue Oct 24, 2024 · 2 comments · Fixed by #1746
Assignees
@ethanoroshiba
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Oct 24, 2024 •
edited
Loading

We should rename all instances of source_action_index to position_in_transaction to be clearer about what this field means.

┆Issue Number: ENG-950
@ethanoroshiba ethanoroshiba added sequencer pertaining to the astria-sequencer crate code-quality labels Oct 24, 2024
@ethanoroshiba ethanoroshiba self-assigned this Oct 24, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Oct 24, 2024
Merged
@SuperFluffy
Copy link
Member

Is this still an open issue? I believe you closed it with #1718?

@ethanoroshiba
Copy link
Contributor Author

Is this still an open issue? I believe you closed it with #1718?

@SuperFluffy there are many instances of source_action_index that I think should still be changed to match, though I realize the issue said sourceActionIndex before. I've adjusted the description accordingly.

@ethanoroshiba ethanoroshiba mentioned this issue Oct 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 2, 2024
@ethanoroshiba
chore(sequencer): change name of source_action_index to `position_i…
ab87d35 
…n_transaction` (#1746)

## Summary
Changed all non-deposit related instances of `source_action_index` to
`position_in_transaction`

## Background
This is meant to be more descriptive and less confusing to consumers.
Deposits should stay the same, though, for parity with Geth and to avoid
breaking changes.

## Changes
- Changed all instances of `source_action_index` to
`position_in_transaction`, excluding deposits..

## Testing
Passing all tests

## Related Issues
closes #1735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(sequencer): change name of source_action_index to position_in_transaction astriaorg/astria
2 participants
@SuperFluffy @ethanoroshiba