Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer is not installing astria-eyre error hook #1551

Closed
SuperFluffy opened this issue Sep 23, 2024 · 0 comments · Fixed by #1552
Closed

Sequencer is not installing astria-eyre error hook #1551

SuperFluffy opened this issue Sep 23, 2024 · 0 comments · Fixed by #1552
Assignees
@ethanoroshiba
Labels
bug Something isn't working sequencer pertaining to the astria-sequencer crate

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Sep 23, 2024 •
edited by sync-by-unito bot
Loading

PR #1387 switched sequencer from anyhow to eyre, but did not set the astria-eyre error hook.

It should call astria_eyre::install before any eyre repots are constructed:

astria/crates/astria-eyre/src/lib.rs

Line 33 in f11f900

pub fn install() -> Result<()> {

┆Issue Number: ENG-839
@SuperFluffy SuperFluffy added bug Something isn't working sequencer pertaining to the astria-sequencer crate labels Sep 23, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Sep 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 24, 2024
@ethanoroshiba
fix(sequencer): install astria-eyre hook (#1552)
c1cc5e5 
## Summary
Added `astria_eyre::install()` call to `main.rs`.

## Background
#1387 switched the sequencer
from `anyhow` to `eyre` usage, but did not install the `astria-eyre`
error hook.

## Changes
Added `astria_eyre::install()` call to `main.rs`.

## Testing
Passing all tests

## Related Issues
closes #1551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
bug Something isn't working sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sequencer): install astria-eyre hook astriaorg/astria
2 participants
@SuperFluffy @ethanoroshiba