Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor onchain OHLC ws endpoint #55

Merged
merged 3 commits into from
Jun 13, 2024
Merged

feat: refactor onchain OHLC ws endpoint #55

merged 3 commits into from
Jun 13, 2024

Conversation

EvolveArt
Copy link
Contributor

@EvolveArt EvolveArt commented Jun 12, 2024 •
edited
Loading

Changes

  • Removed all path and query params from the ohlc ws route
  • All params are now passed through subscription message
  • Only one pair can be subscribed on this endpoint

Motivation for this change is AWS API Gateway.

@EvolveArt EvolveArt requested a review from akhercha June 12, 2024 21:06
akhercha
akhercha approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment suggestion

@EvolveArt @akhercha
Update utils.rs
42369e9 
Co-authored-by: adel <akherchache@pm.me>
@EvolveArt EvolveArt merged commit 67a5c66 into main Jun 13, 2024
4 of 5 checks passed
@EvolveArt EvolveArt deleted the fix/ws-endpoint branch June 13, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhercha akhercha akhercha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvolveArt @akhercha