Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed currencies table + Merkle feeds route + All decimals to 18 #184

Merged
merged 10 commits into from
Feb 26, 2025

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Feb 26, 2025

Resolves: #180 #181 #182

👩‍🏭 In progress...

  • Removed all Merkle feeds related stuff
  • Removed the Currencies table
  • Find a new way to find decimals for on-chain pairs, gonna be either:
    A. on chain rpc calls to get_decimals,
    B. new indexing table for the on-chain db, which indexes events SubmittedCurrency & UpdatedCurrency
  • Find a way to find our abstract currencies. Probably just gonna be a constant.
  • Consider that we have 18 decimals everywhere in our code
  • Add the necessary code to be 100% sure that the entries we are receiving from publishers are quoted with 18 decimals - unplanned, does not look feasible.

@akhercha akhercha self-assigned this Feb 26, 2025
@akhercha akhercha changed the title dev: Removed currencies table + Merkle feeds route refactor: Removed currencies table + Merkle feeds route Feb 26, 2025
@akhercha akhercha changed the title refactor: Removed currencies table + Merkle feeds route refactor: Removed currencies table + Merkle feeds route + All decimals to 18 Feb 26, 2025
@akhercha akhercha marked this pull request as ready for review February 26, 2025 13:08
@akhercha akhercha requested a review from EvolveArt February 26, 2025 13:12
akhercha and others added 4 commits February 26, 2025 15:01
* tests(e2e_get_entry): get_entry simple

* tests(e2e_get_entry): removed to_owned

* tests(e2e_get_entry): removed postgre from CI

* tests(e2e_get_entry): Added nextest config

* tests(e2e_get_entry): test OK

* tests(e2e_get_entry): OK for multiple intervals

* tests(e2e_get_entry): increased startup timeout

* tests(e2e_get_entry): Increase startup timeout for pragma nod

* tests(e2e_get_entry): Local mode for integration tests

* test: e2e get_entry for strk/eth (#185)

* tests: add fake datas

* tests: deps

* tests: more tests

* tests: more tests

* tests: fix view refresh call

* tests: add twap table

* tests: fix routing many

* tests: fix twap

* tests: uncomment

* tests: fix

* tests: remove pairs const

* tests: lint

* tests(e2e_get_entry): toml lint

* tests(e2e_get_entry): Removed one test

* tests(e2e_get_entry): Fixed deadlock

* tests(e2e_get_entry): Removed outliers filtering

---------

Co-authored-by: Rémi <33517098+Remsko@users.noreply.github.com>
@akhercha akhercha merged commit e794c05 into dev Feb 26, 2025
1 check passed
@akhercha akhercha deleted the remove-currencies-and-merkle branch February 26, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant