Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(windows): Introduce setup-dev-drive.ps1, maximize dev drive usage #6858

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

fasterthanlime
Copy link
Contributor

As suggested by @samypr100 on #6680:
#6680 (comment)

Summary

Instead of using UV_INTERNAL__TEST_DIR, it simply exports TEMP when running Windows jobs.

Test Plan

I'm going to run this manually under ProcMon on my Windows machine and see where uv writes temp files, hopefully to the dev drive and not %(LOCAL)APPDATA% or something.

I'm going to commit a dummy code change and look at build time changes in CI.

@fasterthanlime
Copy link
Contributor Author

fasterthanlime commented Aug 30, 2024

So: in uv/tests/common, there's a bit of code that makes a directory under the data dir. There's a rationale for macOS.

We need to keep exporting the internal var for Windows, I'm afraid, but I think setting TEMP there is also a good idea (for other tools), and I've deduplicated the dev-drive setup into its own PowerShell script. Let's see if it still works.

@fasterthanlime fasterthanlime changed the title ci(windows): Simply use the TEMP dir ci(windows): Introduce setup-dev-drive.ps1, maximize dev drive usage Aug 30, 2024
@zanieb zanieb added the testing Internal testing of behavior label Aug 30, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's any interest, I also maintain a separate https://github.com/samypr100/setup-dev-drive which could help achieve the same here if we want to cleanup and have more control on the settings per job

@charliermarsh charliermarsh merged commit 3e207da into astral-sh:main Aug 30, 2024
57 checks passed
"DEV_DRIVE=$($Drive)" `
"TMP=$($Tmp)" `
"TEMP=$($Tmp)" `
"UV_INTERNAL__TEST_DIR=$($Tmp)" `
Copy link
Collaborator

@samypr100 samypr100 Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was UV_INTERNAL__TEST_DIR going to be removed as part of this PR? Maybe a testing remnant

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is addressed in #6858 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks

Copy link
Contributor Author

@fasterthanlime fasterthanlime Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can't be (woops, zanieb got to this first)

#6858 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants