-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(windows): Introduce setup-dev-drive.ps1, maximize dev drive usage #6858
Conversation
As suggested by @samypr100 on astral-sh#6680: astral-sh#6680 (comment)
…o all tools can benefit from it
So: in We need to keep exporting the internal var for Windows, I'm afraid, but I think setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's any interest, I also maintain a separate https://github.com/samypr100/setup-dev-drive which could help achieve the same here if we want to cleanup and have more control on the settings per job
"DEV_DRIVE=$($Drive)" ` | ||
"TMP=$($Tmp)" ` | ||
"TEMP=$($Tmp)" ` | ||
"UV_INTERNAL__TEST_DIR=$($Tmp)" ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was UV_INTERNAL__TEST_DIR
going to be removed as part of this PR? Maybe a testing remnant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is addressed in #6858 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can't be (woops, zanieb got to this first)
As suggested by @samypr100 on #6680:
#6680 (comment)
Summary
Instead of using
UV_INTERNAL__TEST_DIR
, it simply exportsTEMP
when running Windows jobs.Test Plan
I'm going to run this manually under ProcMon on my Windows machine and see where uv writes temp files, hopefully to the dev drive and not
%(LOCAL)APPDATA%
or something.I'm going to commit a dummy code change and look at build time changes in CI.