Use cached environments in PEP 723 execution #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
performance
charliermarsh
force-pushed
the
charlie/cache-pep723-script
branch
2 times, most recently
from
a9faa43 to
636d23e
Compare
charliermarsh
force-pushed
the
charlie/cache-tool-run
branch
from
0abdc3a to
180562e
Compare
charliermarsh
force-pushed
the
charlie/cache-pep723-script
branch
from
636d23e to
10838d9
Compare
konstin
approved these changes
Jul 4, 2024
charliermarsh
force-pushed
the
charlie/cache-pep723-script
branch
from
10838d9 to
0949afe
Compare
zanieb
approved these changes
Jul 4, 2024
charliermarsh
force-pushed
the
charlie/cache-pep723-script
branch
3 times, most recently
from
e92b082 to
84a2da6
Compare
Fixes stack overflows in tests for #4791
charliermarsh
force-pushed
the
charlie/cache-pep723-script
branch
from
84a2da6 to
ab3b621
Compare
Peiffap
reviewed
Jul 4, 2024
| @@ -126,4 +126,9 @@ impl CachedEnvironment { | |||
|
|
|||
| Ok(Self(venv)) | |||
| } | |||
|
|
|||
| /// Convert the [`EphemeralEnvironment`] into an [`Interpreter`]. | |||
There was a problem hiding this comment.
This reintroduced EphemeralEnvironment after you changed it in #4804. There's a few other places where the comments still need to be changed but given that the file is littered with TODOs I'll just comment here rather than open a PR and create merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This seems like another good candidate for environment caching. If you run a script repeatedly, we can just use the existing cached environment.