Use optimized versions of managed Python on Linux #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Di-Is
changed the title
uv python command with optimized oneuv python command with optimized one
|
:D of course I see this after I've debugged it and found this is the problem. Glad we agree though! Thanks for opening a pull request. |
zanieb
approved these changes
Jul 3, 2024
zanieb
changed the title
uv python command with optimized one
helderco
reviewed
Jul 5, 2024
Comment on lines
-21
to
+22
| "url": "https://github.com/indygreg/python-build-standalone/releases/download/20240415/cpython-3.12.3%2B20240415-aarch64-unknown-linux-gnu-debug-full.tar.zst", | ||
| "sha256": "24daaf20123ac4b2b8657c1ac8227d391d2e5769d81237b68ee674569d307ad0" | ||
| "url": "https://github.com/indygreg/python-build-standalone/releases/download/20240415/cpython-3.12.3%2B20240415-aarch64-unknown-linux-gnu-lto-full.tar.zst", | ||
| "sha256": "a4f17d1e3b4ea0e4c2a3664f232c0857979522936af582f7de92b57050220f74" |
There was a problem hiding this comment.
The archive for lto is more than 3 times the size of debug.
Looking at the docs, there's an Install Only Archive. Does uv need the full variant?
cpython-3.12.3+20240415-aarch64-unknown-linux-gnu-debug-full.tar.zst 48MB
cpython-3.12.3+20240415-aarch64-unknown-linux-gnu-lto-full.tar.zst 178MB
cpython-3.12.3+20240415-aarch64-unknown-linux-gnu-install_only.tar.gz 24.4MB
There was a problem hiding this comment.
I'm not sure why Rye opted not to use these (and our download preferences are based on the implementation over there). Here's an issue for discussion #4834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4774.
Summary
Change the python interpreter for linux installed with
uv pythonto an optimized one.Test Plan
I ran the following command on Linux (glibc) to confirm that an optimized (not debug built) Python is installed.