Replace tool environments on updated Python request #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/tool-env
branch
from
7c52935 to
39fc800
Compare
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/tool-env
branch
2 times, most recently
from
37d2dc3 to
75d9c7e
Compare
charliermarsh
commented
Jul 2, 2024
charliermarsh
commented
Jul 2, 2024
| let python_request = python.as_deref().map(ToolchainRequest::parse); | ||
|
|
||
| // Pre-emptively identify a Python interpreter. We need an interpreter to resolve any unnamed | ||
| // requirements, even if we end up using a different interpreter for the tool install itself. |
There was a problem hiding this comment.
This is somewhat annoying.
There was a problem hiding this comment.
(Not a behavior change, just forced to explain why now. I'm not sure how to avoid it. I can try to make it lazy.)
zanieb
reviewed
Jul 2, 2024
zanieb
reviewed
Jul 2, 2024
zanieb
approved these changes
Jul 2, 2024
charliermarsh
force-pushed
the
charlie/tool-env
branch
from
75d9c7e to
c791127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4741.