Lock for the duration of tool commands

[zanieb]

Feedback from #4501 (comment)

[zanieb]

Ah this is a bit annoying because now we're locking the directory before we make sure it exists, which I preferred to have happen once we knew we wanted to mutate it so we weren't creating during inspection. I'm not sure how much this matters in practice.

[charliermarsh]

Ah this is a bit annoying because now we're locking the directory before we make sure it exists, which I preferred to have happen once we knew we wanted to mutate it so we weren't creating during inspection. I'm not sure how much this matters in practice.

Where is this happening in the code? I think it's ok though.

[zanieb]

@charliermarsh you can see the CI failures are due to the lock being acquired without init first which throws an error. Previously, we waited to call init until we needed do something.

[charliermarsh]

Ahh sorry yes, that makes sense.

[BurntSushi]

My little nit here is to use a different word than "safe" in the comments, just to avoid it being confusable with the Rust concept of safety. Maybe, "correct" instead?