-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dedicated message for tools with no entrypoints #4694
Conversation
f6398e4
to
aa436d6
Compare
Should we... fail? I feel like it doesn't "mean" anything to install a tool with no entry points. |
I mildly prefer not failing. |
Separately, I just noticed your example: we should probably have a message for installation of Ruff's executable. |
If there are no provided executables or entry points.. what is installing a tool? |
Ruff is fixed in #4693. |
It puts the tool in a dedicated environment on your machine. In theory you could run that environment if you wanted an isolated environment with the tool? I don't know the use-case but failing seems user-hostile. Anyway you can decide, I don't feel the need to keep discussing. |
One data point:
|
That seems like two votes for erroring, so I'll do that. |
aa436d6
to
a0c82af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we can revisit later, but yeah right now the environments are intended not to be user-facing and I'd recommend some other command for the no-entrypoints use case.
Yeah all good! |
Summary
Closes #4688.
Test Plan