-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid enforcing extra-only constraints #4570
Merged
+77
−12
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1302,15 +1302,6 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag | |
) -> impl Iterator<Item = &'a Requirement> { | ||
self.overrides | ||
.apply(dependencies) | ||
.flat_map(|requirement| { | ||
iter::once(requirement).chain( | ||
// If the requirement was constrained, add those constraints. | ||
self.constraints | ||
.get(&requirement.name) | ||
.into_iter() | ||
.flatten(), | ||
) | ||
}) | ||
.filter(move |requirement| { | ||
// If the requirement would not be selected with any Python version | ||
// supported by the root, skip it. | ||
|
@@ -1353,8 +1344,50 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag | |
} | ||
} | ||
} | ||
|
||
true | ||
}) | ||
.flat_map(move |requirement| { | ||
iter::once(requirement).chain( | ||
self.constraints | ||
.get(&requirement.name) | ||
.into_iter() | ||
.flatten() | ||
.filter(move |constraint| { | ||
if !satisfies_requires_python(self.requires_python.as_ref(), constraint) { | ||
trace!( | ||
"skipping {constraint} because of Requires-Python {requires_python}", | ||
requires_python = self.requires_python.as_ref().unwrap() | ||
); | ||
return false; | ||
} | ||
|
||
if !possible_to_satisfy_markers(markers, constraint) { | ||
trace!("skipping {constraint} because of context resolver markers {markers}"); | ||
return false; | ||
} | ||
|
||
// If the constraint isn't relevant for the current platform, skip it. | ||
match extra { | ||
Some(source_extra) => { | ||
if !constraint.evaluate_markers( | ||
self.markers.as_ref(), | ||
std::slice::from_ref(source_extra), | ||
) { | ||
return false; | ||
} | ||
} | ||
None => { | ||
if !constraint.evaluate_markers(self.markers.as_ref(), &[]) { | ||
return false; | ||
} | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is almost the same as above but not quite (the filtering on extras is different), just as it was prior to the refactor (intentionally so). |
||
|
||
true | ||
}), | ||
) | ||
}) | ||
} | ||
|
||
/// Fetch the metadata for a stream of packages and versions. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key is that we shouldn't apply the constraints here; we only apply them after we've filtered requirements.