Add --extra to uv add and enable fine grained updates
#4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
force-pushed
the
ibraheem/uv-add-update
branch
from
9d7793f to
65b723a
Compare
| fn update_requirement(old: &mut Requirement, new: Requirement, has_source: bool) { | ||
| // Add any new extras. | ||
| old.extras.extend(new.extras); | ||
| old.extras.dedup(); |
There was a problem hiding this comment.
I don't think so? This is updating pyproject.toml not the lockfile.
There was a problem hiding this comment.
But dedup only deduplicates adjacent entries, right?
There was a problem hiding this comment.
Oh right, fixed. I wonder if extras should be a HashSet..
ibraheemdev
force-pushed
the
ibraheem/uv-add-update
branch
from
65b723a to
682939f
Compare
charliermarsh
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--extraflag touv addthat allows activating extras without the PEP508 syntax.uv addnow errors if the update is ambiguous (e.g. the dependency is present twice with different markers)uv addis smarter about updates. For example,uv add flask==3.0.0followed byuv add flask --extra dotenvpreserves the previous version specifier.Resolves #4419.