Add support for --no-strip-markers in pip compile output
#4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/req-txt
branch
6 times, most recently
from
c222eab to
effc56e
Compare
charliermarsh
added
the
enhancement
charliermarsh
force-pushed
the
charlie/req-txt
branch
from
effc56e to
a651af0
Compare
konstin
approved these changes
Jun 25, 2024
| // Fold over the edges to combine the marker trees. If any edge is `None`, then | ||
| // the combined marker tree is `None`. | ||
| let mut edges = petgraph.edges_directed(index, Direction::Incoming); | ||
| edges |
There was a problem hiding this comment.
Can this be simplified with a let makers = edges.iter() ... .collect(); if !markers.is_empty() { MarkerTree::Or(markers)}?
There was a problem hiding this comment.
The nice thing about the current solution is that it doesn't allocate a vec.
charliermarsh
force-pushed
the
charlie/req-txt
branch
2 times, most recently
from
82c6ea1 to
21f68a8
Compare
charliermarsh
force-pushed
the
charlie/req-txt
branch
from
21f68a8 to
63c943b
Compare
charliermarsh
force-pushed
the
charlie/req-txt
branch
from
63c943b to
d41022e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an intermediary change in enabling universal resolution for
requirements.txtfiles. To start, we need to be able to preserve markers in therequirements.txtoutput and propagate those markers, such that if you have a dependency that's only included with a given marker, the transitive dependencies respect that marker too.Closes #1429.