Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip submodule update for fresh clones #4482

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Skip submodule update for fresh clones #4482

merged 1 commit into from
Jun 24, 2024

Conversation

charliermarsh
Copy link
Member

Summary

We unconditionally update the submodules in our Git code, but AFAICT it shouldn't be necessary if we already have a complete, up-to-date fetch available.

@charliermarsh charliermarsh added the performance Potential performance improvement label Jun 24, 2024
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me, we call .reset() for every checkout.

@charliermarsh charliermarsh merged commit 7d3fb43 into main Jun 24, 2024
46 of 47 checks passed
@charliermarsh charliermarsh deleted the charlie/sub branch June 24, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Potential performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants