Allow multiple toolchains to be requested in uv toolchain install
#4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-install-many
branch
from
7d30506 to
ab7d5ae
Compare
konstin
approved these changes
Jun 17, 2024
zanieb
force-pushed
the
zb/toolchain-request-key
branch
3 times, most recently
from
35a2730 to
31a937a
Compare
zanieb
force-pushed
the
zb/toolchain-install-many
branch
2 times, most recently
from
7b18221 to
677b392
Compare
zanieb
force-pushed
the
zb/toolchain-request-key
branch
from
31a937a to
717799e
Compare
zanieb
force-pushed
the
zb/toolchain-install-many
branch
2 times, most recently
from
278c5c0 to
af9eeb1
Compare
BurntSushi
approved these changes
Jun 17, 2024
| if targets.is_empty() { | ||
| writeln!( | ||
| printer.stderr(), | ||
| "A toolchain is already installed. Use `uv toolchain install <request>` to install a specific toolchain.", |
There was a problem hiding this comment.
I think the idea here is that if this message is printed, then I think it's guaranteed that some other "Found installed toolchain ..." message is printed above it, right?
There was a problem hiding this comment.
Also, should this say, "all requested toolchains are already installed"? Instead of just saying only a single toolchain is already installed?
There was a problem hiding this comment.
Yeah that's the idea. The output is actually pretty reasonable with both messages, one is listing discovered toolchains and the other summarizes the result of the whole operation.
We only say this when the targets are empty, which means we're looking for any managed toolchain. This is a special case added in #4248
zanieb
force-pushed
the
zb/toolchain-install-many
branch
from
af9eeb1 to
25427db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows installation of multiple toolchains in a single invocation because I don't want to be limited to one! Most of the implementation for concurrent downloads ported from
cargo dev fetch-python.