Improve handling of missing interpreters during discovery #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jun 10, 2024
Comment on lines
-141
to
-142
| error: failed to canonicalize path `[VENV]/Scripts/python.exe` | ||
| Caused by: The system cannot find the path specified. (os error 3) |
There was a problem hiding this comment.
Oh hey this is way better, why would we fail here anyway?
There was a problem hiding this comment.
Yeah I'm actually not sure.
There was a problem hiding this comment.
Well I know why we did but yeah there's no reason to
zanieb
commented
Jun 10, 2024
crates/uv/tests/pip_sync.rs
Outdated
| error: failed to canonicalize path `[VENV]/bin/python3` | ||
| Caused by: No such file or directory (os error 2) | ||
| error: No Python interpreters found in virtual environments |
There was a problem hiding this comment.
Now this isn't amazing, I guess with -v you'd see why your VIRTUAL_ENV was ignored. We could add some sort of hint in the future?
There was a problem hiding this comment.
Since it literally doesn't exist this seems okay for now though
charliermarsh
approved these changes
Jun 10, 2024
This feels kind of obvious, but the query code never checked if the requested interpreter exists so we would fail with an IO error and stop discovery which does not feel quite right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #4214
The first commit gets us some context on an IO error during queries:
Previously:
Now:
but really we shouldn't attempt to query a missing interpreter during discovery anyway, so we improve handling of that too.