Add uv toolchain install
#4164
Merged
Add uv toolchain install
#4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-v-ii
branch
3 times, most recently
from
abf3421 to
48f0edd
Compare
zanieb
force-pushed
the
zb/toolchain-v-i
branch
2 times, most recently
from
b3f708c to
943c963
Compare
zanieb
force-pushed
the
zb/toolchain-v-ii
branch
from
48f0edd to
bfdea67
Compare
charliermarsh
approved these changes
Jun 10, 2024
konstin
approved these changes
Jun 10, 2024
zanieb
force-pushed
the
zb/toolchain-v-ii
branch
from
bfdea67 to
4e68eaa
Compare
ibraheemdev
pushed a commit
that referenced
this pull request
Jun 11, 2024
## Summary Something that looks like it was forgotten to replace in #4164. ## Test Plan Run `cargo run toolchain install` should display the warning: ``warning: `uv toolchain install` is experimental and may change without warning.``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command (following #4163) to download and install specific toolchains. While we fetch toolchains on demand, this is useful for, e.g., pre-downloading a toolchain in a Docker image build.
I kind of think we should call thisI changed the name frominstallinstead offetchfetchtoinstall.