Avoid enforcing distribution ID uniqueness for extras #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to do some more refactors to make this mistake harder / clearer in the future, but I'll do that separately. |
BurntSushi
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Yeah I think the original intent here is that an ID would uniquely identify a distribution, and that a Dependency was just a reference to a distribution. But a Dependency has evolved a bit to include additional information (and it might include more), so I think this is right...
|
Yeah I might change this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The condition enforced here isn't quite right. The same dependency can appear multiple times, as long as the extra is different.
Closes #4101.