Avoid building packages with dynamic versions #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/static
branch
from
c28ffdf to
2380cc3
Compare
|
Ok, I'm happy with how little special-casing this required, even if it requires ~200 LoC. |
charliermarsh
force-pushed
the
charlie/static
branch
2 times, most recently
from
37c3435 to
803f1d6
Compare
charliermarsh
force-pushed
the
charlie/static
branch
from
803f1d6 to
14fa60f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates "gathering the requirements" from the rest of the metadata (e.g., version), which isn't required when installing a package's dependencies (as opposed to installing the package itself). It thus ensures that we don't need to build a package when a static
pyproject.tomlis provided inpip compile.Closes #4040.