Use lockfile versions as resolution preferences #3921
Conversation
| @@ -52,6 +52,11 @@ impl Lock { | |||
| Lock::try_from(wire) | |||
| } | |||
|
|
|||
| /// Returns the [`Distribution`] entries in this lock. | |||
| pub fn distributions(&self) -> &[Distribution] { | |||
There was a problem hiding this comment.
@BurntSushi - Let me know if you have a preferred way to do this (other than what's here). I expose Distribution, but none of the fields or methods are pub.
There was a problem hiding this comment.
I think this looks fine.
The thing I care about most is not exposing representation. I don't mean to say we shouldn't do it, but that's where the biggest benefit is. If we don't expose representation, then it makes it much easier to change that representation in the future. (It's all a trade off.)
| @@ -52,6 +52,11 @@ impl Lock { | |||
| Lock::try_from(wire) | |||
| } | |||
|
|
|||
| /// Returns the [`Distribution`] entries in this lock. | |||
| pub fn distributions(&self) -> &[Distribution] { | |||
There was a problem hiding this comment.
I think this looks fine.
The thing I care about most is not exposing representation. I don't mean to say we shouldn't do it, but that's where the biggest benefit is. If we don't expose representation, then it makes it much easier to change that representation in the future. (It's all a trade off.)
charliermarsh
force-pushed
the
charlie/preferences
branch
from
ba453ef to
8214453
Compare
charliermarsh
changed the base branch from
konsti/move-requirement-to-pypi-types
to
main
charliermarsh
force-pushed
the
charlie/preferences
branch
from
8214453 to
d7f803b
Compare
CodSpeed Performance ReportMerging #3921 will degrade performances by 6.17%Comparing Summary
Benchmarks breakdown
|
Summary
Ensures that we avoid upgrading packages unless
--upgradeor similar is passed.For now, the resolver only respects these for registry distributions.
Closes #3918.