Gate discovery of managed toolchains with preview #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-preview-mode
branch
2 times, most recently
from
98c39c7 to
3f02b9d
Compare
zanieb
force-pushed
the
zb/toolchain-preview-mode
branch
from
3f02b9d to
35d0714
Compare
zanieb
commented
May 25, 2024
| Self::VirtualEnv => f.write_str("virtual environments"), | ||
| Self::System => { | ||
| // TODO(zanieb): We intentionally omit managed toolchains for now since they are not public | ||
| Self::System(preview) => { |
There was a problem hiding this comment.
I'll probably rethink this display in a future change.
zanieb
commented
May 25, 2024
Comment on lines
-415
to
+416
| let sources = SourceSelector::All; | ||
| let sources = SourceSelector::All(PreviewMode::Enabled); |
There was a problem hiding this comment.
We turn on preview so we discover managed toolchains when finding the Python versions requested by tests.
charliermarsh
force-pushed
the
zb/data-dir-toolchain
branch
from
9517162 to
8f2c59b
Compare
charliermarsh
force-pushed
the
zb/toolchain-preview-mode
branch
from
35d0714 to
e84bbf7
Compare
charliermarsh
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares for merge of #3797, gating managed toolchain discovery with the preview flag to lower risk of releasing.
e.g.
We'll add automatic fetching of managed interpreters later.