Move maturin test coverage into CI #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/maturin-test
branch
3 times, most recently
from
3cf58cc to
84d073d
Compare
|
Can we just remove this entirely? Seems like a lot of complexity to have an maintain job just for this. |
|
I don't feel strongly, we could remove it. Why did @konstin think coverage was important? |
|
My goal here is immediately unblock the rest of my PRs which are failing due to this test. It's trivial to remove after this merges so I have a preference to merge this as-is and consider dropping coverage separately. |
|
Ok, feel free to merge, I'll remove in a separate PR then. Bias towards action :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can take over 60s to run, which is too much for a unit test. We'll run it in a separate CI job to retain coverage.