Use top-level --isolated for uv run
#3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
cli
zanieb
reviewed
May 7, 2024
Comment on lines
-1827
to
-1829
| /// Always use a new virtual environment for execution. | ||
| #[arg(long)] | ||
| pub(crate) isolated: bool, |
There was a problem hiding this comment.
This (behavior) was useful for testing, but oh well I can add it back if I need it.
zanieb
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already have a global
--isolated, which means "ignore any on-disk configuration". I think we should reuse this for the "ignore the workspace" setting inuv run, rather than--no-workspace.I've also merged the existing
--isolatedand--no-workspacebehaviors inuv runinto a single flag. We may not need separate flags for this, since the current intent seems to be "ignore the workspace environment"? Though we could always re-add later.Closes #3421.