Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cache against latest release in CI #2714

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Test cache against latest release in CI #2714

merged 1 commit into from
Mar 28, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Mar 28, 2024

Detect cache incompatibility issues like #2711 by testing against the last version of uv continuously

@zanieb zanieb added the testing Internal testing of behavior label Mar 28, 2024
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a decent sanity check. I wonder if it might be better to install something bigger like homeassistant to get a bigger sampling of packages.

This won't catch silent errors, but I think it will at least catch some subset of errors that rkyv validation doesn't catch.

@zanieb
Copy link
Member Author

zanieb commented Mar 28, 2024

I'll test homeassistant and choose something prudent for test suite runtime

@BurntSushi
Copy link
Member

Yeah, it looks like getting a broader sampling here matters. Things are hunky dory with anyio:

$ uv cache clean && rm -rf .venv
Clearing cache at: /home/andrew/.cache/uv
Removed 41594 files (246.2MiB)

$ uv-0.1.24 venv
Using Python 3.12.0 interpreter at: /home/andrew/.pyenv/versions/3.12.0/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate

$ uv-0.1.24 pip install anyio
Resolved 3 packages in 80ms
Downloaded 3 packages in 23ms
Installed 3 packages in 5ms
 + anyio==4.3.0
 + idna==3.6
 + sniffio==1.3.1

$ uv-0.1.25 pip install anyio --reinstall-package anyio
Resolved 3 packages in 25ms
Installed 1 package in 6ms
 - anyio==4.3.0
 + anyio==4.3.0

But homeassistant lets me repro:

$ uv cache clean && rm -rf .venv
Clearing cache at: /home/andrew/.cache/uv
Removed 41598 files (246.2MiB)

$ uv-0.1.24 venv
Using Python 3.12.0 interpreter at: /home/andrew/.pyenv/versions/3.12.0/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate

$ uv-0.1.24 pip install -q homeassistant

$ uv-0.1.25 pip install -q homeassistant --reinstall-package homeassistant
error: Failed to download and build: pyric==0.1.6.3
  Caused by: Failed to deserialize cache entry
  Caused by: expected version to start with a number, but no leading ASCII digits were found

@zanieb zanieb force-pushed the zb/cache-test branch 6 times, most recently from 015bb80 to df69024 Compare March 28, 2024 18:34
@zanieb zanieb requested a review from BurntSushi March 28, 2024 18:36
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@zanieb zanieb enabled auto-merge (squash) March 28, 2024 18:44
@zanieb zanieb merged commit b36f5d8 into main Mar 28, 2024
32 of 33 checks passed
@zanieb zanieb deleted the zb/cache-test branch March 28, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants