-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim injected python_version
marker to (major, minor)
#2395
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,31 @@ | ||
use pep440_rs::Version; | ||
use pep508_rs::MarkerEnvironment; | ||
use pep508_rs::{MarkerEnvironment, StringVersion}; | ||
use uv_interpreter::Interpreter; | ||
|
||
#[derive(Debug, Clone, Eq, PartialEq, Ord, PartialOrd)] | ||
#[derive(Debug, Clone, Eq, PartialEq)] | ||
pub struct PythonRequirement { | ||
/// The installed version of Python. | ||
installed: Version, | ||
installed: StringVersion, | ||
/// The target version of Python; that is, the version of Python for which we are resolving | ||
/// dependencies. This is typically the same as the installed version, but may be different | ||
/// when specifying an alternate Python version for the resolution. | ||
target: Version, | ||
target: StringVersion, | ||
} | ||
|
||
impl PythonRequirement { | ||
pub fn new(interpreter: &Interpreter, markers: &MarkerEnvironment) -> Self { | ||
Self { | ||
installed: interpreter.python_version().clone(), | ||
target: markers.python_full_version.version.clone(), | ||
installed: interpreter.python_full_version().clone(), | ||
target: markers.python_full_version.clone(), | ||
} | ||
} | ||
|
||
/// Return the installed version of Python. | ||
pub fn installed(&self) -> &Version { | ||
pub fn installed(&self) -> &StringVersion { | ||
&self.installed | ||
} | ||
|
||
/// Return the target version of Python. | ||
pub fn target(&self) -> &Version { | ||
pub fn target(&self) -> &StringVersion { | ||
&self.target | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same value, I just renamed the method because it's the
python_full_version
marker.