Fallback to fresh request on non-validating 304 #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/304
branch
from
ed6bb86 to
e5c4608
Compare
charliermarsh
added
compatibility
charliermarsh
force-pushed
the
charlie/304
branch
from
461543f to
23c4a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're seeing reports that Sonatype Nexus isn't working with cached data. Users are reporting 304 responses that show "Found modified response..." path in the logs. I can't reproduce this on latest Sonatype Nexus, but my best guess is that there's a 304 response that is failing our validators, and we try to use that as if it's a "complete" response?
Closes #1754.