Error when editables don't match Requires-Python
#2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
reviewed
Mar 5, 2024
| @@ -389,6 +391,21 @@ async fn build_editables( | |||
| .into_iter() | |||
| .collect(); | |||
|
|
|||
| // Validate that the editables are compatible with the target Python version. | |||
There was a problem hiding this comment.
Not that I know anything about uv codebase but FTR this fix should also be applied on non-editable local installs. (appologies if that's already done).
Thanks for working on this!
There was a problem hiding this comment.
I thought we already enforced those, but I guess not! Will do it in a separate PR, thanks.
charliermarsh
force-pushed
the
charlie/req
branch
2 times, most recently
from
c600124 to
1c420b0
Compare
charliermarsh
force-pushed
the
charlie/req
branch
from
1c420b0 to
0271010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2192.
Test Plan
cargo test