Query interpreter to determine correct virtualenv paths
#2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/venv-paths
branch
2 times, most recently
from
275eac8 to
a3fb98d
Compare
charliermarsh
added
compatibility
charliermarsh
force-pushed
the
charlie/venv-paths
branch
3 times, most recently
from
906278c to
8b2bf50
Compare
charliermarsh
commented
Mar 5, 2024
| "pypy" | ||
| } else { | ||
| "python" | ||
| } |
There was a problem hiding this comment.
E.g., this is no longer necessary.
charliermarsh
force-pushed
the
charlie/venv-paths
branch
from
b58858e to
36fde0e
Compare
charliermarsh
force-pushed
the
charlie/venv-paths
branch
from
36fde0e to
26263f1
Compare
konstin
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates our virtualenv creation from a setup that assumes prior knowledge of the correct paths, to a technique borrowed from
virtualenvwhereby we usesysconfiganddistutilsto determine the paths. The general trick is to grab the expected paths withsysconfig, then make them all relative, then make them absolute for a given directory.Closes #2095.
Closes #2153.