Use more universal windows install instructions #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommend installing puffin with ``` powershell -c "irm https://github.com/axodotdev/cargo-dist/releases/latest/download/cargo-dist-installer.ps1 | iex" ``` instead of ``` irm https://github.com/axodotdev/cargo-dist/releases/latest/download/cargo-dist-installer.ps1 | iex ``` to support installing on cmd.exe, the classic non-powershell windows terminal. See axodotdev/cargo-dist#458 for background. This will also be included in the next cargo-dist release.
konstin
added
the
enhancement
charliermarsh
approved these changes
Feb 21, 2024
|
Seems reasonable to me. Running it locally made me aware that this calls the Windows Powershell installation (I have profile customizations that aren't compatible with the windows power shell and they fail). Do we know if this works on systems that only have powershell installed but not the system powershell? I believe GitHub Windows uses pws7.exe. Can we try if the command works inside of a runner (sorry, I know it's pain to try these things out) |
zanieb
approved these changes
Feb 21, 2024
zanieb
added
documentation
AlexWaygood
pushed a commit
that referenced
this pull request
Feb 21, 2024
|
Works on github actions: https://github.com/astral-sh/uv/actions/runs/8002095518/job/21854609649?pr=1811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend installing uv on windows with
instead of
to support installing on cmd.exe, the classic non-powershell windows command prompt.
See axodotdev/cargo-dist#458 for background. This will also be included in the next cargo-dist release.
I have confirmed this passes on
Closes #1750
CC @12932 this fixes the uv command prompt installation.