Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve executable bit when untarring archives #1790

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Preserve executable bit when untarring archives #1790

merged 2 commits into from
Feb 21, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #1767.

Test Plan

Not sure -- I don't think has come up yet?

@charliermarsh charliermarsh added the bug Something isn't working label Feb 21, 2024
@charliermarsh charliermarsh force-pushed the charlie/tar branch 4 times, most recently from 1b07f82 to ae15bbd Compare February 21, 2024 01:36
konstin
konstin reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do this in sync::archive, too (or remove that branch).

konstin
konstin approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do this in sync::archive, too (or remove that branch).

Fixed by #1809

@charliermarsh
Copy link
Member Author

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) February 21, 2024 14:15
@charliermarsh charliermarsh merged commit 19890fe into main Feb 21, 2024
7 checks passed
@charliermarsh charliermarsh deleted the charlie/tar branch February 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb left review comments

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preserve executable when unpacking tars
3 participants
@charliermarsh @zanieb @konstin