Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry local clones without hardlinks if they fail #11421

Merged
merged 3 commits into from
Feb 12, 2025
Merged

retry local clones without hardlinks if they fail #11421

merged 3 commits into from
Feb 12, 2025
+13 −2

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Feb 11, 2025

Fixes #11420

@Gankra
Copy link
Contributor Author

Gankra commented Feb 11, 2025

I need to setup BeeGFS to check that this really works.

@Gankra Gankra added the bug Something isn't working label Feb 11, 2025
@Gankra Gankra changed the base branch from main to tracking/060 February 11, 2025 17:03
@Gankra Gankra changed the base branch from tracking/060 to main February 11, 2025 17:03
@PhilipVinc
Copy link
Contributor

PhilipVinc commented Feb 11, 2025 •
edited
Loading

If you give me a built linux executable I can try for you, if you want.

@Gankra
Copy link
Contributor Author

Gankra commented Feb 11, 2025

Oh great! The PR CI already built one:

https://github.com/astral-sh/uv/actions/runs/13266446923/artifacts/2572423342

@PhilipVinc
Copy link
Contributor

Dammit. Unfortunately on my system I have only GLIBC 2.17 available, but you require 2.18...

@PhilipVinc
Copy link
Contributor

PhilipVinc commented Feb 11, 2025 •
edited
Loading

@Gankra I managed to use the musl builds.

It seems there is a typo:

  Caused by: process didn't exit successfully: `/usr/bin/git clone --no-hard-links /mnt/beegfs/home/CPHT/filippo.vicentini/.cache/uv/git-v0/db/292f78b3ecf26bf6 /mnt/beegfs/home/CPHT/filippo.vicentini/.cache/uv/git-v0/checkouts/292f78b3ecf26bf6/f1db6bb` (exit status: 129)
--- stderr
error: unknown option `no-hard-links'
usage: git clone [options] [--] <repo> [<dir>]

    -v, --verbose         be more verbose
    -q, --quiet           be more quiet
    --progress            force progress reporting
    -n, --no-checkout     don't create a checkout
    --bare                create a bare repository
    --mirror              create a mirror repository (implies bare)
    -l, --local           to clone from a local repository
    --no-hardlinks        don't use local hardlinks, always copy
    -s, --shared          setup as shared repository

It should be --no-hardlinks but you specified --no-hard-links

@charliermarsh
Copy link
Member

You can use the musl wheel, hopefully? It's under https://github.com/astral-sh/uv/actions/runs/13266446923/artifacts/2572463068.

@charliermarsh @PhilipVinc
Update crates/uv-git/src/git.rs
70a4a85 
Co-authored-by: Filippo Vicentini <filippovicentini@gmail.com>
@charliermarsh
Copy link
Member

Thanks. I triggered a rebuild.

@charliermarsh
Copy link
Member

The updated musl version is https://github.com/astral-sh/uv/actions/runs/13272737821/artifacts/2574639236.

@PhilipVinc
Copy link
Contributor

tested. It works. thanks!

@charliermarsh
Copy link
Member

Great, thanks! I'll leave to @Gankra to merge.

@charliermarsh charliermarsh marked this pull request as ready for review February 12, 2025 00:42
@charliermarsh charliermarsh merged commit ba5efa8 into main Feb 12, 2025
73 checks passed
@charliermarsh charliermarsh deleted the gankra/harder branch February 12, 2025 00:42
@charliermarsh
Copy link
Member

(Confirmed in Discord.)

@BrewTestBot BrewTestBot mentioned this pull request Feb 12, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 13, 2025
@tmeijn
build(deps): update astral-sh/uv to v0.5.31
8e4d707 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.30` -> `0.5.31` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.31`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0531)

[Compare Source](astral-sh/uv@0.5.30...0.5.31)

##### Enhancements

-   Add `uv sync --script` ([#&#8203;11361](astral-sh/uv#11361))
-   Allow PEP 508 requirements in tool requests ([#&#8203;11337](astral-sh/uv#11337))
-   Allow source distributions to produce wheels with `+local` suffixes ([#&#8203;11429](astral-sh/uv#11429))
-   Bring parity to `uvx` and `uv tool install` requests ([#&#8203;11345](astral-sh/uv#11345))
-   Use a stable directory for local, remote, and stdin script virtual environments ([#&#8203;11347](astral-sh/uv#11347), [#&#8203;11364](astral-sh/uv#11364))
-   Detect infinite recursion in `uv run` ([#&#8203;11386](astral-sh/uv#11386))

##### Python

The managed Python distributions have been updated, including:

-   CPython 3.14.0a5, which includes a new [tail calling interpreter](https://docs.python.org/3.14/whatsnew/3.14.html#whatsnew314-tail-call) for a significant performance improvement
-   The bundled OpenSSL version was updated from 3.0.15 to 3.0.16 which fixes a [security advisory](https://openssl-library.org/news/secadv/20241016.txt)

See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250212) for more details.

##### Bug fixes

-   Fix cross-drive script installation ([#&#8203;11167](astral-sh/uv#11167))
-   Add indexes in priority order ([#&#8203;11451](astral-sh/uv#11451))
-   Allow `--python <dir>` requests to match existing environments if `sys.executable` is the same file ([#&#8203;11290](astral-sh/uv#11290))
-   Avoid comparing to system site packages in `--dry-run` mode ([#&#8203;11427](astral-sh/uv#11427))
-   Prefer running executables in the environment with `<name>` over `<name>/__main__.py` ([#&#8203;11431](astral-sh/uv#11431))
-   Retry local clones without hardlinks if they fail ([#&#8203;11421](astral-sh/uv#11421))

##### Documentation

-   Update alternative-indexes.md to use `UV_INDEX` instead of `UV_EXTRA_INDEX_URL` ([#&#8203;11381](astral-sh/uv#11381))
-   Update scripts guide to include using package indexes ([#&#8203;11443](astral-sh/uv#11443))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjYuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipVinc PhilipVinc PhilipVinc left review comments

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

installing git repository ignores UV_LINK_MODE, breaks on some filesystems
3 participants
@Gankra @PhilipVinc @charliermarsh