-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious test failures related to Windows permissions on temporary directory #6940
Comments
Duplicate of #6789 — better title though. |
Maybe since #6680 ? I wonder if this is a real bug that's just surfaced now? |
(Sorry for the dupe, thanks.) |
Shouldn't the temp dir need to be created before tests start to run?
|
Oh is this related to #6929 ? Why would it work sometimes? |
Thats the first difference from before and after I can think about. In CI, C: drive already had a temp drive ahead of time, where as the dev drive doesn't. Assuming the errors started happening after those PRs. Given env:tmp_dir does not ensure the dir exists, I assumed this being a potential cause. |
A suggested solution to #6940 — unfortunately only time will tell if it works.
Another example
|
|
|
|
Some observations
|
|
|
Cherry-picked from astral-sh#8347 Might fix astral-sh#6940 — I'm not seeing a failure over there after this change. I think there may be some problem with concurrent reads of junctioned files on the DevDrive? It's really hard to say. We might lose some important test coverage with this change. I'm not sure what to do about that either.
The text was updated successfully, but these errors were encountered: