Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Python version on uv init #6821

Closed
zanieb opened this issue Aug 29, 2024 · 3 comments · Fixed by #6869
Closed

Pin Python version on uv init #6821

zanieb opened this issue Aug 29, 2024 · 3 comments · Fixed by #6869
Assignees
@charliermarsh
Labels
projects Related to project management capabilities

Comments

@zanieb
Copy link
Member

zanieb commented Aug 29, 2024

See #6780

Might want #4970 first, but I don't think it's blocking.

Basically, we should pin the Python version for the project on init. We should allow opt-out with --no-pin-python.
@zanieb zanieb added good first issue Good for newcomers projects Related to project management capabilities labels Aug 29, 2024
@charliermarsh
Copy link
Member

For app and lib?

@zanieb
Copy link
Member Author

zanieb commented Aug 29, 2024

I think so — either way you want to develop on a consistent version.

@charliermarsh charliermarsh self-assigned this Aug 30, 2024
@charliermarsh charliermarsh mentioned this issue Aug 30, 2024
Merged
@samypr100
Copy link
Collaborator

samypr100 commented Aug 30, 2024 •
edited
Loading

In the spirit of this comment #6780 (comment), wouldn't we want to opt-in with --pin-python instead of opting out? Even on app mode I typically see just minimum major.minor on the requires-python metadata field where as .python-version does contain a pinned version.

nvm, I realized this issue refers to .python-version and not requires-python.

@charliermarsh charliermarsh removed the good first issue Good for newcomers label Sep 3, 2024
charliermarsh added a commit that referenced this issue Sep 3, 2024
@charliermarsh
Pin .python-version in uv init (#6869)
50d7b9c 
## Summary

I'm not convinced that the behavior is correct as-implemented. When the
user passes a `--python >=3.8` or we discover a `requires-python` from
the workspace, we're currently writing that request out to
`.python-version`. I would probably rather that we write the resolved
patch version?

Closes #6821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
projects Related to project management capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin .python-version in uv init astral-sh/uv
3 participants
@charliermarsh @zanieb @samypr100