Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed toolchain discovery doesn't reflect ARM v6 vs. v7 differences #3857

Closed
charliermarsh opened this issue May 27, 2024 · 0 comments · Fixed by #4236
Closed

Managed toolchain discovery doesn't reflect ARM v6 vs. v7 differences #3857

charliermarsh opened this issue May 27, 2024 · 0 comments · Fixed by #4236
Assignees
@zanieb
Labels
bug Something isn't working preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

See: #3855 (comment)
@charliermarsh charliermarsh added the bug Something isn't working label May 27, 2024
@charliermarsh charliermarsh mentioned this issue Jun 9, 2024
Closed
@zanieb zanieb added the preview Experimental behavior label Jun 9, 2024
@zanieb zanieb self-assigned this Jun 9, 2024
@zanieb zanieb mentioned this issue Jun 11, 2024
Merged
zanieb added a commit that referenced this issue Jun 12, 2024
@zanieb
Refactor uv-toolchain::platform to use target-lexicon (#4236)
f7f55ed 
Closes #3857

Instead of using custom `Arch`, `Os`, and `Libc` types I just use
`target-lexicon`'s which enumerate way more variants and implement
display and parsing. We use a wrapper type to represent a couple special
cases to support the "x86" alias for "i686" and "macos" for "darwin".
Alternatively we could try to use our `platform-tags` types but those
capture more information (like operating system versions) that we don't
have for downloads.

As discussed in #4160, this is not
sufficient for proper libc detection but that work is larger and will be
handled separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanieb zanieb

Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor uv-toolchain::platform to use target-lexicon astral-sh/uv
2 participants
@charliermarsh @zanieb