Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing resolution error message #3710

Closed
ibraheemdev opened this issue May 21, 2024 · 1 comment · Fixed by #3711
Closed

Confusing resolution error message #3710

ibraheemdev opened this issue May 21, 2024 · 1 comment · Fixed by #3711
Labels
error messages Messaging when something goes wrong resolver Related to the package resolver

Comments

@ibraheemdev
Copy link
Member

ibraheemdev commented May 21, 2024 •
edited
Loading

From this CI failure:

× No solution found when resolving dependencies:
╰─▶ Because pandas-stubs==2.0.3.230814 depends on numpy>=1.25.0 and you
require numpy==1.24.4, we can conclude that you require==0a0.dev0 and
pandas-stubs==2.0.3.230814 are incompatible.
And because you require pandas-stubs==2.0.3.230814, we can conclude that
the requirements are unsatisfiable.

The requirements.txt was generated on a different platform than CI, should be able to reproduce by running pip install on this file, on Ubuntu (though there may be some other marker environments involved).
@ibraheemdev ibraheemdev added error messages Messaging when something goes wrong resolver Related to the package resolver labels May 21, 2024
@zanieb
Copy link
Member

zanieb commented May 21, 2024

Fixing the bad error message

@zanieb zanieb mentioned this issue May 21, 2024
Merged
zanieb added a commit that referenced this issue May 21, 2024
@zanieb
Improve display of root package in range errors (#3711)
c14a7db 
Instead of saying 

> we can conclude that you require==0a0.dev0 and
pandas-stubs==2.0.3.230814 are incompatible.

we'll say

> we can conclude that your requirements and pandas-stubs==2.0.3.230814
are incompatible.

Closes #3710 

I'm not sure how to get unit test coverage for this, might look into
that. Ideally we'd skip this branch entirely?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
error messages Messaging when something goes wrong resolver Related to the package resolver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve display of root package in range errors astral-sh/uv
2 participants
@zanieb @ibraheemdev