Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool.uv.sources needs to preserve verbatim representation #3366

Closed
charliermarsh opened this issue May 4, 2024 · 3 comments · Fixed by #3412
Closed

tool.uv.sources needs to preserve verbatim representation #3366

charliermarsh opened this issue May 4, 2024 · 3 comments · Fixed by #3412
Labels
bug Something isn't working preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

See: https://github.com/astral-sh/uv/pull/3263/files#r1589862490
@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels May 4, 2024
@konstin
Copy link
Member

konstin commented May 6, 2024

My idea was the pyproject.toml doesn't allow env vars; we can support relative paths properly and authentication and indexes with dedicated configuration.

@charliermarsh
Copy link
Member Author

But we don't currently output relative paths when writing to requirements.txt. Is that not a bug?

@konstin
Copy link
Member

konstin commented May 6, 2024

I see, that should indeed be fixed

konstin added a commit that referenced this issue May 6, 2024
@konstin
Preserve given for tool.uv.sources paths
3014a5b 
We now correctly emit relative paths in `uv pip compile` with `tool.uv.sources` path inputs.

`tool.uv.sources` is mainly intended to be used with the uv lock file over requirements.txt, but it's good to have basic `uv pip` support working.

Fixes #3366
@konstin konstin mentioned this issue May 6, 2024
Merged
charliermarsh pushed a commit that referenced this issue May 7, 2024
@konstin
Preserve given for tool.uv.sources paths (#3412)
24f38d7 
We now correctly emit relative paths in `uv pip compile` with
`tool.uv.sources` path inputs.

`tool.uv.sources` is mainly intended to be used with the uv lock file
over requirements.txt, but it's good to have basic `uv pip` support
working.

Fixes #3366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve given for tool.uv.sources paths astral-sh/uv
2 participants
@charliermarsh @konstin