Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyringProvider::fetch_subprocess should be async #3073

Closed
zanieb opened this issue Apr 16, 2024 · 4 comments · Fixed by #3089
Closed

KeyringProvider::fetch_subprocess should be async #3073

zanieb opened this issue Apr 16, 2024 · 4 comments · Fixed by #3089
Assignees
Labels
good first issue Good for newcomers performance Potential performance improvement

Comments

@zanieb
Copy link
Member

zanieb commented Apr 16, 2024

As far as I can tell, we're egregiously blocking the event loop for 80ms on keyring fetches. The function should be async and use an async subprocess API.

@zanieb zanieb added good first issue Good for newcomers performance Potential performance improvement labels Apr 16, 2024
@zanieb
Copy link
Member Author

zanieb commented Apr 16, 2024

See https://docs.rs/tokio/latest/tokio/process/struct.Command.html

fn fetch_subprocess(&self, service_name: &str, username: &str) -> Option<String> {

@naosense
Copy link
Contributor

See https://docs.rs/tokio/latest/tokio/process/struct.Command.html

fn fetch_subprocess(&self, service_name: &str, username: &str) -> Option<String> {

hey@zanieb i want to try this, could you assign it to me?

@charliermarsh
Copy link
Member

Done @naosense thanks!

@zanieb
Copy link
Member Author

zanieb commented Apr 17, 2024

Sweet let me know if you have any questions. The KeyringProvider::fetch API will need to become async too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers performance Potential performance improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants