Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no-op --no-compile #2771

Closed
henryiii opened this issue Apr 2, 2024 · 8 comments · Fixed by #2816
Closed

Support no-op --no-compile #2771

henryiii opened this issue Apr 2, 2024 · 8 comments · Fixed by #2816
Assignees
Labels
compatibility Compatibility with a specification or another tool

Comments

@henryiii
Copy link
Contributor

henryiii commented Apr 2, 2024

It would be nice to simply ignore --no-compile, rather than throw an error, to make it easier to swap pip and uv.

@charliermarsh charliermarsh self-assigned this Apr 2, 2024
@charliermarsh charliermarsh added the compatibility Compatibility with a specification or another tool label Apr 2, 2024
@charliermarsh
Copy link
Member

Thanks, I assumed we did this already. Will add.

@sam-goodwin
Copy link

sam-goodwin commented Apr 3, 2024

I think I ran into this with uv pip compile. Just wanted a way to create a requirements.txt from pyproject.toml but it built pyspark which took 1-2 minutes. Expected the operation to be instant.

@zanieb
Copy link
Member

zanieb commented Apr 3, 2024

@sam-goodwin this is totally separate — --no-compile means do not compile .pyc files. You're looking for --only-binary.

@henryiii
Copy link
Contributor Author

henryiii commented Apr 3, 2024

That's not what --no-compile means. It means skip making .pyc files from .py files, which uv already does, and is opt-in for pip.

@sam-goodwin
Copy link

Thanks @zanieb and @henryiii , sorry for the confusion.

@staaam
Copy link

staaam commented Jun 23, 2024

@charliermarsh I'd like to reopen this issue, since --no-compile flag is still not support. Getting this error:

$ uv pip install --no-compile test
error: unexpected argument '--no-compile' found

  tip: a similar argument exists: '--no_compile'

which kind of misses the point (tested on uv==0.2.13)

@charliermarsh
Copy link
Member

It's --no-compile-bytecode, but we can add an alias.

@charliermarsh
Copy link
Member

Fixed in #4453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility with a specification or another tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants