Buffer writes to archive entries #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
reviewed
Feb 3, 2025
Comment on lines
-702
to
+711
| let to = SeekFrom::Current(d.limit() as i64); | ||
| let size = f.seek(to).await?; | ||
| f.set_len(size).await?; | ||
| let pad_len = d.limit() as i64; | ||
| writer.flush().await?; | ||
| let f = writer.get_mut(); | ||
| let new_size = f.seek(SeekFrom::Current(pad_len)).await?; | ||
| f.set_len(new_size).await?; |
There was a problem hiding this comment.
Is there documentation on when we need this padding and how the seek/set_len trick works?
charliermarsh
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 3, 2025
## Summary I shipped one security fix here along with several significant performance improvements for large TAR files: - astral-sh/tokio-tar#2 - astral-sh/tokio-tar#4 - astral-sh/tokio-tar#5 I also PR'd the security fix to `edera-dev` (edera-dev/tokio-tar#4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For a large PyTorch wheel, this improves performance by about 20%.