Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit typos action #4876

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix pre-commit typos action #4876

merged 1 commit into from
Jun 6, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Jun 5, 2023

The typos pre-commit action would previously edit test fixtures and snapshots. Unfortunately the pre-commit action also doesn't respect _typos.toml and typos action doesn't allow for an exclude key, so i've added a top level exclude key. I have confirmed that this does stop typos from rewriting my fixtures and snapshots

The typos pre-commit action would also edit test fixtures and snapshots. Unfortunately the pre-commit action also doesn't respect _typos.toml and typos action doesn't allow for an exclude key, so i've added a top level exclude key. I have confirmed that this does stop typos from rewriting my fixtures and snapshots
@konstin
Copy link
Member Author

konstin commented Jun 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Jun 5, 2023
@konstin konstin added the internal An internal refactor or improvement label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.2±0.23ms     5.6 MB/sec    1.01      7.3±0.21ms     5.6 MB/sec
formatter/numpy/ctypeslib.py               1.00  1487.7±53.50µs    11.2 MB/sec    1.03  1536.4±62.66µs    10.8 MB/sec
formatter/numpy/globals.py                 1.00   171.3±10.42µs    17.2 MB/sec    1.01   173.2±14.06µs    17.0 MB/sec
formatter/pydantic/types.py                1.00      3.2±0.16ms     7.9 MB/sec    1.01      3.2±0.11ms     7.9 MB/sec
linter/all-rules/large/dataset.py          1.02     18.4±0.45ms     2.2 MB/sec    1.00     18.0±0.48ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.3±0.22ms     3.9 MB/sec    1.00      4.2±0.16ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.00   540.1±24.57µs     5.5 MB/sec    1.00   539.2±23.28µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.6±0.24ms     3.3 MB/sec    1.00      7.5±0.29ms     3.4 MB/sec
linter/default-rules/large/dataset.py      1.02      8.9±0.26ms     4.6 MB/sec    1.00      8.7±0.33ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.05  1876.3±61.63µs     8.9 MB/sec    1.00  1790.3±67.13µs     9.3 MB/sec
linter/default-rules/numpy/globals.py      1.02    217.4±8.53µs    13.6 MB/sec    1.00   212.5±11.18µs    13.9 MB/sec
linter/default-rules/pydantic/types.py     1.07      4.0±0.13ms     6.4 MB/sec    1.00      3.7±0.11ms     6.8 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.11      9.0±0.44ms     4.5 MB/sec    1.00      8.1±0.45ms     5.0 MB/sec
formatter/numpy/ctypeslib.py               1.10  1880.3±93.13µs     8.9 MB/sec    1.00  1714.3±70.94µs     9.7 MB/sec
formatter/numpy/globals.py                 1.02   196.5±11.70µs    15.0 MB/sec    1.00   193.2±16.78µs    15.3 MB/sec
formatter/pydantic/types.py                1.06      3.8±0.21ms     6.7 MB/sec    1.00      3.6±0.13ms     7.1 MB/sec
linter/all-rules/large/dataset.py          1.05     21.6±0.79ms  1929.9 KB/sec    1.00     20.5±0.60ms  2027.6 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.04      5.3±0.26ms     3.1 MB/sec    1.00      5.1±0.15ms     3.3 MB/sec
linter/all-rules/numpy/globals.py          1.00   612.5±27.47µs     4.8 MB/sec    1.00   611.4±37.67µs     4.8 MB/sec
linter/all-rules/pydantic/types.py         1.05      9.1±0.43ms     2.8 MB/sec    1.00      8.7±0.29ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.04     10.3±0.41ms     3.9 MB/sec    1.00     10.0±0.34ms     4.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.1±0.08ms     7.8 MB/sec    1.00      2.1±0.10ms     7.8 MB/sec
linter/default-rules/numpy/globals.py      1.14   263.9±47.30µs    11.2 MB/sec    1.00   232.2±16.46µs    12.7 MB/sec
linter/default-rules/pydantic/types.py     1.04      4.6±0.33ms     5.5 MB/sec    1.00      4.4±0.18ms     5.8 MB/sec

@konstin konstin merged commit 7753267 into main Jun 6, 2023
@konstin konstin deleted the fix-pre-commit-typos branch June 6, 2023 06:06
konstin added a commit that referenced this pull request Jun 13, 2023
The typos pre-commit action would also edit test fixtures and snapshots. Unfortunately the pre-commit action also doesn't respect _typos.toml and typos action doesn't allow for an exclude key, so i've added a top level exclude key. I have confirmed that this does stop typos from rewriting my fixtures and snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants