Document LinterResult::has_syntax_error and add Parsed::has_no_errors

crates/ruff_linter/src/linter.rs

@@ -42,6 +42,8 @@ pub struct LinterResult {
     pub messages: Vec<Message>,
     /// A flag indicating the presence of syntax errors in the source file.
     /// If `true`, at least one syntax error was detected in the source file.
+    ///
+    /// This includes both [`ParseError`]s and [`UnsupportedSyntaxError`]s.
     pub has_syntax_error: bool,
 }
 
@@ -445,7 +447,7 @@ pub fn lint_only(
             &locator,
             &directives,
         ),
-        has_syntax_error: !parsed.is_valid() || !parsed.unsupported_syntax_errors().is_empty(),
+        has_syntax_error: !parsed.has_no_errors(),
     }
 }
 
@@ -546,7 +548,7 @@ pub fn lint_fix<'a>(
         );
 
         if iterations == 0 {
-            is_valid_syntax = parsed.is_valid() && parsed.unsupported_syntax_errors().is_empty();
+            is_valid_syntax = parsed.has_no_errors();
         } else {
             // If the source code was parseable on the first pass, but is no
             // longer parseable on a subsequent pass, then we've introduced a

crates/ruff_python_parser/src/lib.rs

@@ -346,10 +346,20 @@ impl<T> Parsed<T> {
     ///
     /// Note that this does not include version-related
     /// [`unsupported_syntax_errors`](Parsed::unsupported_syntax_errors).
+    ///
+    /// See [`has_no_errors`](Parsed::has_no_errors) for a version that takes these into account.
     pub fn is_valid(&self) -> bool {
         self.errors.is_empty()
     }
 
+    /// Returns `true` if the parsed source code does not contain any [`ParseError`]s *or*
+    /// [`UnsupportedSyntaxError`]s.
+    ///
+    /// See [`Parsed::is_valid`] for a version specific to [`ParseError`]s.
+    pub fn has_no_errors(&self) -> bool {
+        self.is_valid() && self.unsupported_syntax_errors.is_empty()
+    }
+
     /// Returns the [`Parsed`] output as a [`Result`], returning [`Ok`] if it has no syntax errors,
     /// or [`Err`] containing the first [`ParseError`] encountered.
     ///

crates/ruff_python_parser/tests/fixtures.rs

@@ -39,7 +39,7 @@ fn test_valid_syntax(input_path: &Path) {
     });
     let parsed = parse_unchecked(&source, options);
 
-    let is_valid = parsed.is_valid() && parsed.unsupported_syntax_errors().is_empty();
+    let is_valid = parsed.has_no_errors();
 
     if !is_valid {
         let line_index = LineIndex::from_source_text(&source);
@@ -101,7 +101,7 @@ fn test_invalid_syntax(input_path: &Path) {
     });
     let parsed = parse_unchecked(&source, options);
 
-    let is_valid = parsed.is_valid() && parsed.unsupported_syntax_errors().is_empty();
+    let is_valid = parsed.has_no_errors();
 
     assert!(
         !is_valid,